zhreshold commented on pull request #18358:
URL: https://github.com/apache/incubator-mxnet/pull/18358#issuecomment-632947318


   @leezu Fix to mem leak is nice to have and I don't see any problem with this 
pariticular PR, however, `deepcopy` of a full network isn't a rare usecase 
which means a fix to deepcopy is needed anyway. 
   
   In fact, the behavior of `__deepcopy__` of a `Block` has to be overrided 
with the `_BlockScope` being renewed in the new `Block`, and the suspicious 
copy behavior of parameters has to be verified and secured.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to