szha commented on a change in pull request #18393:
URL: https://github.com/apache/incubator-mxnet/pull/18393#discussion_r429599165
##########
File path: src/operator/numpy/np_true_divide-inl.h
##########
@@ -306,7 +306,7 @@ void TrueDivideBroadcastCompute(const nnvm::NodeAttrs&
attrs,
} else {
if (common::is_float(lhs.type_flag_) &&
common::is_float(rhs.type_flag_)) {
// lhs and rhs have different float types, the output is the more
precise one
- LOG(ERROR) << "not implemented yet...";
+ LOG(FATAL) << "not implemented yet...";
Review comment:
We should use
```
LOG(FATAL) << "NotImplementedError: xxx setting for yyy op is not
implemented yet.";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
