mseth10 commented on pull request #18394:
URL: https://github.com/apache/incubator-mxnet/pull/18394#issuecomment-636762790
@eric-haibin-lin I see that we have removed a lot of examples and tests as
part of this PR. What is the plan to handle code that refers to these files.
For example, the script `tests/python/train/test_conv.py` is referred to at
several places in the repo (which also breaks the CD pipeline):
```
cd/python/docker/test_python_image.sh:44:python3
tests/python/train/test_conv.py ${test_conv_params}
ci/docker/runtime_functions.sh:1941: python3
/work/mxnet/tests/python/train/test_conv.py ${test_conv_params}
docker/docker-python/build_python_dockerfile.sh:61: docker run -v
${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version}
/mxnet/tests/python/train/test_conv.py"
docker/docker-python/build_python_dockerfile.sh:70: nvidia-docker run -v
${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version}
/mxnet/tests/python/train/test_conv.py --gpu"
docker/docker-python/README.md:50:*
[test_conv.py](https://github.com/apache/incubator-mxnet/blob/master/tests/python/train/test_conv.py)
docs/static_site/src/pages/api/faq/s3_integration.md:73:Let's modify an
existing example code in MXNet repository to read data from S3 instead of local
disk.
[`mxnet/tests/python/train/test_conv.py`](https://github.com/dmlc/mxnet/blob/master/tests/python/train/test_conv.py)
trains a convolutional network using MNIST data from local disk. We'll do the
following change to read the data from S3 instead.
docs/static_site/src/pages/api/faq/s3_integration.md:76:~/mxnet$ sed -i --
's/data\//s3:\/\/bucket-name\/training-data\//g'
./tests/python/train/test_conv.py
docs/static_site/src/pages/api/faq/s3_integration.md:78:~/mxnet$ git diff
./tests/python/train/test_conv.py
docs/static_site/src/pages/api/faq/s3_integration.md:79:diff --git
a/tests/python/train/test_conv.py b/tests/python/train/test_conv.py
docs/static_site/src/pages/api/faq/s3_integration.md:81:---
a/tests/python/train/test_conv.py
docs/static_site/src/pages/api/faq/s3_integration.md:82:+++
b/tests/python/train/test_conv.py
docs/static_site/src/pages/api/faq/s3_integration.md:104:After the above
change `test_conv.py` will fetch data from S3 instead of the local disk.
docs/static_site/src/pages/api/faq/s3_integration.md:107:python
./tests/python/train/test_conv.py
```
This is one example. There might be similar issues with other files that are
removed in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
