ChaiBapchya commented on a change in pull request #26:
URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r433377330
##########
File path: services/jenkins-pipeline-monitor/handler.py
##########
@@ -87,11 +95,21 @@ def filter_by_desired_release_job_type(latest_day_builds,
desired_release_job_ty
def status_check(builds):
- for build in builds:
- if build.get_status() == 'SUCCESS':
- logging.info(f'Successful build {get_release_job_type(build)}
{build.get_number()}')
- else:
- logging.info(f'Failure build {get_release_job_type(build)}
{build.get_number()}')
+ """
+ Check the status of the filtered builds
+ If there is not a single build belong to desired release job type, log the
failures
+ else check the status via Jenkins API and report accordingly
+ :param builds
+ """
+ if not builds:
Review comment:
Addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
