leezu commented on a change in pull request #18450:
URL: https://github.com/apache/incubator-mxnet/pull/18450#discussion_r433569813
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -187,13 +187,50 @@ build_dynamic_libmxnet() {
ninja
}
+build_onnx_and_onnx_tensorrt() {
+ set -ex
+ # Build ONNX
+ pushd .
+ echo "Installing ONNX."
+ cd 3rdparty/onnx-tensorrt/third_party/onnx
+ rm -rf build
+ mkdir -p build
+ cd build
+ cmake \
+ -DCMAKE_CXX_FLAGS=-I/usr/include/python${PYVER}\
Review comment:
I think the problem is that we're using a 2 years old version of onnx
via the onnx tensorrt. That version seems to require Python 2. I suggest you
update the submodule tensorrt onnx submodule to the latest release which
hopefully supports Python 3.
This should be unrelated to ninja and above CMAKE_CXX_FLAGS
I would suggest not to introduce such symlink, as the upstream scripts may
fail in subtle ways when switching from python2 to python3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
