iblis17 commented on a change in pull request #18461:
URL: https://github.com/apache/incubator-mxnet/pull/18461#discussion_r433970996
##########
File path: julia/deps/build.jl
##########
@@ -133,7 +133,7 @@ if !libmxnet_detected
name = "mxnet_x64_$(HAS_CUDA ? "vc141_gpu_cu101" : "vc14_cpu").7z"
package_url =
"https://github.com/yajiedesign/mxnet/releases/download/$(curr_win)/$(curr_win)_$(name)"
- exe7z = joinpath(Sys.BINDIR, "7z.exe")
+ exe7z = joinpath(Sys.BINDIR, Base.LIBEXECDIR, "7z.exe")
Review comment:
ref:
https://github.com/JuliaLang/julia/issues/33687#issuecomment-555257501
```suggestion
if isdefined(Base, :LIBEXECDIR)
exe7z = joinpath(Sys.BINDIR, Base.LIBEXECDIR, "7z.exe")
else
exe7z = joinpath(Sys.BINDIR, "7z.exe")
end
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
