leezu commented on a change in pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#discussion_r434742570



##########
File path: cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy
##########
@@ -24,7 +24,7 @@
 
 // NOTE: the following variables are referenced in the mxnet_lib_pipeline 
jenkins file imported bellow
 // libmxnet location
-libmxnet = 'lib/libmxnet.so'

Review comment:
       Thank you Manu. As with the 1.7 PR: Changing this line is done when 
switching to cmake build on CD. I don't think it's done yet (but we certainly 
want to do it at some point to decrease the infrastructure code divergence 
between 1.x and master branch)
   
   So I suggest to remove this line in the PR and have a separate PR for the 
build change later




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to