sxjscience commented on a change in pull request #18492:
URL: https://github.com/apache/incubator-mxnet/pull/18492#discussion_r436047924
##########
File path: src/operator/nn/cudnn/cudnn_batch_norm-inl.h
##########
@@ -228,7 +228,7 @@ class CuDNNBatchNormOp {
&a,
&b,
&a,
- req[cudnnbatchnorm::kGamma] == kWriteTo ? &b: &b_add,
+ req[cudnnbatchnorm::kGamma] == kAddTo ? &b_add : &b,
Review comment:
@zhreshold I believe there are some `grad_req = add` issues in BN. Would
you know if there are cases that `gamma.grad_req = write` and `beta.grad_req =
add`? If not, we may just raise an error in the OP if it happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
