leezu commented on issue #18412: URL: https://github.com/apache/incubator-mxnet/issues/18412#issuecomment-639983273
Thanks @acphile! I think we can consider if the `param.name` attribute is really needed. Instead we can solely rely on the structure based naming scheme. This is because I'm afraid that the `set_prefix` approach may not be completely robust (users may access the `param.name` before the prefix is set). I put an example at the code review: https://github.com/apache/incubator-mxnet/pull/18413#pullrequestreview-425619757 What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
