acphile commented on a change in pull request #18413:
URL: https://github.com/apache/incubator-mxnet/pull/18413#discussion_r436435238
##########
File path: tests/python/unittest/test_gluon_estimator.py
##########
@@ -394,24 +388,6 @@ def test_val_net():
val_loss=val_loss,
val_net=val_net)
- with pytest.raises(RuntimeError):
- est.fit(train_data=dataloader,
- val_data=dataloader,
- epochs=num_epochs)
-
- ''' test weight sharing of sequential networks with namescope '''
Review comment:
Actually test for new method of weight sharing exists. Originally, there
are two tests: "test weight sharing of sequential networks with namescope" and
"test weight sharing of sequential networks without namescope". Since in new
API, we don't have to define children block inside "with net.name_scope()", I
remove one of the tests. You can see in "def _get_test_network(params=None)", I
maintain the original test for weight sharing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
