iblis17 commented on a change in pull request #18515:
URL: https://github.com/apache/incubator-mxnet/pull/18515#discussion_r437984016
##########
File path: julia/src/visualize.jl
##########
@@ -207,7 +207,8 @@ function _format_graphviz_edge(io::IOBuffer, head, tail,
attrs)
_format_graphviz_attr(io, attrs)
end
function _extract_shape(str :: AbstractString)
- shape = matchall(r"\d+", str)
+ shape = collect(m.match for m in eachmatch(r"\d+", str))
+
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
