sxjscience commented on pull request #18319: URL: https://github.com/apache/incubator-mxnet/pull/18319#issuecomment-642180856
@leezu I recommend having another PR to fix the implementation in the imperative side. The reason is that there are lots of different scenarios of advanced indexing, e.g., boolean + integer + broadcasting + ... See: https://github.com/apache/incubator-mxnet/blob/26f44b71d8de84bbc88af496ae0aeb7ce535312d/python/mxnet/numpy/multiarray.py#L722-L732 We need to add more test cases if we are going to move this OP to the imperative API. I suggest doing it together with the defered_compute test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
