RuRo commented on pull request #18525: URL: https://github.com/apache/incubator-mxnet/pull/18525#issuecomment-646597349
@eric-haibin-lin can you explain, why did you remove the conversions for `Add`, `Sub`, `Mul` and `Div` operators from onnx to mxnet? Just because it uses the Module API? Isn't this a bit of an overkill? :confused: AFAIK, the module API is used here just to infer the shapes of inputs, so it should be probably possible to replace the `get_input_shape` call with the newer `get_inputs(..., with_shape=True)` function, which doesn't use the Module API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
