ciyongch commented on a change in pull request #18478:
URL: https://github.com/apache/incubator-mxnet/pull/18478#discussion_r445315141
##########
File path: tools/license_header.py
##########
@@ -100,24 +112,33 @@
'docs/static_site/src/assets/js/clipboard.js',
'cmake/upstream/FindCUDAToolkit.cmake',
'cmake/upstream/select_compute_arch.cmake',
- 'src/operator/numpy/np_einsum_op-inl.h',
# Licensed under 2-Clause BSD in header
'example/ssd/dataset/pycocotools/coco.py',
# Julia package metadata, generated by Pkg3.jl
'julia/Project.toml',
-
+
# Licensed under Apache 2.0 license
-
'example/image-classification/predict-cpp/image-classification-predict.cc'
+
'example/image-classification/predict-cpp/image-classification-predict.cc',
+
+ # This file
+ 'tools/license_header.py',
+
+ # Github template
+ '.github/ISSUE_TEMPLATE/bug_report.md',
+ '.github/ISSUE_TEMPLATE/feature_request.md',
+ '.github/ISSUE_TEMPLATE/flaky_test.md',
+ '.github/PULL_REQUEST_TEMPLATE.md'
Review comment:
Hi @leezu , this piece of license header will invalid the github issue
template as I claimed previously, here's an
[example](https://github.com/ciyongch/incubator-mxnet/issues/new) by adding
[such
header](https://github.com/ciyongch/incubator-mxnet/commit/bce3a531a1392623f9808e66f83233278889cb43)
to .github templates, you'll see that there's not any templates in the issue
page. While the normal one is like
[this](https://github.com/apache/incubator-mxnet/issues/new/choose). That's why
I choose to skip those github template files.
It would be great if you know how to keep the original template
functionality after adding the headers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
