leezu commented on pull request #18319: URL: https://github.com/apache/incubator-mxnet/pull/18319#issuecomment-651328832
@sxjscience @AntiZpvoh thank you for investigating and clarifying the shortcomings. To ensure consistency between the imperative and symbolic interface, how about adding an `if` statement between lines 722 and 723 https://github.com/apache/incubator-mxnet/blob/becb9ca694f51fdc0583d58429ccc943e6462810/python/mxnet/numpy/multiarray.py#L722-L730 to call the operator introduced by @AntiZpvoh when inputs are not boolean. For boolean inputs, we could keep the existing imperative logic. This should be quite straightforward, but please let me know if you disagree. Thereby we prevent divergence of the two interfaces, minimize the chance of subtle bugs and make the code more maintainable by working towards a fully shared implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
