leezu commented on a change in pull request #18625:
URL: https://github.com/apache/incubator-mxnet/pull/18625#discussion_r448684679



##########
File path: ci/build_windows.py
##########
@@ -69,6 +69,7 @@ class BuildFlavour(Enum):
         '-DUSE_DIST_KVSTORE=OFF '
         '-DBUILD_CPP_EXAMPLES=ON '
         '-DUSE_MKL_IF_AVAILABLE=OFF '
+        '-DUSE_INT64_TENSOR_SIZE=ON '

Review comment:
       Let's remove `DUSE_INT64_TENSOR_SIZE=ON` everywhere, as it's the default?

##########
File path: ci/docker/runtime_functions.sh
##########
@@ -512,6 +519,7 @@ build_ubuntu_gpu_clang10_werror() {
        -DMXNET_CUDA_ARCH="$CI_CMAKE_CUDA_ARCH" \
        -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
        -DUSE_CPP_PACKAGE=OFF \
+       -DUSE_INT64_TENSOR_SIZE=OFF \

Review comment:
       Why set it to OFF here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to