[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #18504: [Improvement] Invoke mkldnn and cudnn BatchNorm when axis != 1

[GitBox]

mseth10 commented on a change in pull request #18504:
URL: https://github.com/apache/incubator-mxnet/pull/18504#discussion_r449239778



##########
File path: src/operator/nn/batch_norm.cc
##########
@@ -420,10 +420,14 @@ static bool BatchNormType(const nnvm::NodeAttrs& attrs,
 
 #if MXNET_USE_MKLDNN == 1
 static inline bool SupportMKLDNNBN(const NDArray &input, const BatchNormParam 
&param) {
-  mxnet::TShape shape = input.shape();
-  return SupportMKLDNN(input) && shape.ndim() == 4

Review comment:
       we are removing the check for `ndim == 4` here, and another lighter 
check for `ndim == 1 || ndim ==2 || ndim ==4` present in `SupportMKLDNN`.
   Does that mean `ndim` can be anything >0 ? What are the allowed values for 
`ndim`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org