samskalicky commented on a change in pull request #18405:
URL: https://github.com/apache/incubator-mxnet/pull/18405#discussion_r449832018
##########
File path: python/mxnet/gluon/block.py
##########
@@ -1040,41 +1040,62 @@ def _build_cache(self, *args):
warnings.warn("Parameter %s is not used by any computation. "
"Is this intended?"%unused, stacklevel=4)
- data_indices = []
- param_indices = []
- self._cached_op_args = []
- for i, name in enumerate(input_names):
- if name in data_names:
- data_indices.append(i)
- self._cached_op_args.append((True, data_names[name]))
- else:
- param_indices.append(i)
- self._cached_op_args.append((False, params[name]))
- flags = [('data_indices', data_indices), ('param_indices',
param_indices)] + \
- self._flags
-
args, _ = _flatten(args, "input")
try:
- for is_arg, i in self._cached_op_args:
- if not is_arg:
- i.data()
+ for name in input_names:
+ if name in params:
+ params[name].data()
except DeferredInitializationError:
self._deferred_infer_shape(*args)
- for is_arg, i in self._cached_op_args:
- if not is_arg:
- i._finish_deferred_init()
+ for name in input_names:
+ if name in params:
+ params[name]._finish_deferred_init()
+ arg_dict, aux_dict = dict(), dict()
if self._backend:
ctx = args[0].context
# get list of params in the order of out.list_arguments
- arg_dict = {name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
- for name in out.list_arguments()}
- aux_dict = {name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
- for name in out.list_auxiliary_states()}
+ arg_dict.update({name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
+ for name in out.list_arguments()})
Review comment:
Why do you initialize do you `dict()` and then call update on an empty
dictionary instead of just assigning?
##########
File path: python/mxnet/gluon/block.py
##########
@@ -1040,41 +1040,62 @@ def _build_cache(self, *args):
warnings.warn("Parameter %s is not used by any computation. "
"Is this intended?"%unused, stacklevel=4)
- data_indices = []
- param_indices = []
- self._cached_op_args = []
- for i, name in enumerate(input_names):
- if name in data_names:
- data_indices.append(i)
- self._cached_op_args.append((True, data_names[name]))
- else:
- param_indices.append(i)
- self._cached_op_args.append((False, params[name]))
- flags = [('data_indices', data_indices), ('param_indices',
param_indices)] + \
- self._flags
-
args, _ = _flatten(args, "input")
try:
- for is_arg, i in self._cached_op_args:
- if not is_arg:
- i.data()
+ for name in input_names:
+ if name in params:
+ params[name].data()
except DeferredInitializationError:
self._deferred_infer_shape(*args)
- for is_arg, i in self._cached_op_args:
- if not is_arg:
- i._finish_deferred_init()
+ for name in input_names:
+ if name in params:
+ params[name]._finish_deferred_init()
+ arg_dict, aux_dict = dict(), dict()
if self._backend:
ctx = args[0].context
# get list of params in the order of out.list_arguments
- arg_dict = {name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
- for name in out.list_arguments()}
- aux_dict = {name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
- for name in out.list_auxiliary_states()}
+ arg_dict.update({name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
+ for name in out.list_arguments()})
Review comment:
Why do you initialize do you call `dict()` and then call update on an
empty dictionary instead of just assigning?
##########
File path: python/mxnet/gluon/block.py
##########
@@ -1040,41 +1040,62 @@ def _build_cache(self, *args):
warnings.warn("Parameter %s is not used by any computation. "
"Is this intended?"%unused, stacklevel=4)
- data_indices = []
- param_indices = []
- self._cached_op_args = []
- for i, name in enumerate(input_names):
- if name in data_names:
- data_indices.append(i)
- self._cached_op_args.append((True, data_names[name]))
- else:
- param_indices.append(i)
- self._cached_op_args.append((False, params[name]))
- flags = [('data_indices', data_indices), ('param_indices',
param_indices)] + \
- self._flags
-
args, _ = _flatten(args, "input")
try:
- for is_arg, i in self._cached_op_args:
- if not is_arg:
- i.data()
+ for name in input_names:
+ if name in params:
+ params[name].data()
except DeferredInitializationError:
self._deferred_infer_shape(*args)
- for is_arg, i in self._cached_op_args:
- if not is_arg:
- i._finish_deferred_init()
+ for name in input_names:
+ if name in params:
+ params[name]._finish_deferred_init()
+ arg_dict, aux_dict = dict(), dict()
if self._backend:
ctx = args[0].context
# get list of params in the order of out.list_arguments
- arg_dict = {name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
- for name in out.list_arguments()}
- aux_dict = {name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
- for name in out.list_auxiliary_states()}
+ arg_dict.update({name:args[data_names[name]] if name in
data_names.keys() else params[name].data()
+ for name in out.list_arguments()})
Review comment:
Why do you initialize with `dict()` and then call update on an empty
dictionary instead of just assigning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
