DickJC123 commented on a change in pull request #18622: URL: https://github.com/apache/incubator-mxnet/pull/18622#discussion_r457779449
########## File path: src/common/cuda/rtc.cc ########## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "mxnet/base.h" + +#if MXNET_USE_CUDA + +#include <nvrtc.h> + +#include <mutex> +#include <string> +#include <fstream> +#include <unordered_map> +#include <vector> + +#include "rtc.h" +#include "rtc/half-inl.h" +#include "rtc/util-inl.h" +#include "rtc/forward_functions-inl.h" +#include "rtc/backward_functions-inl.h" +#include "rtc/vectorization-inl.h" +#include "rtc/special_functions-inl.h" +#include "rtc/reducer-inl.h" +#include "utils.h" + + +namespace mxnet { +namespace common { +namespace cuda { +namespace rtc { + +std::mutex lock; + +namespace util { + +std::string to_string(OpReqType req) { + switch (req) { + case kNullOp: + return "OpReqType::kNullOp"; + case kWriteTo: + case kWriteInplace: + return "OpReqType::kWriteTo"; + case kAddTo: + return "OpReqType::kAddTo"; + } + LOG(FATAL) << "Unrecognized req."; + return ""; +} + +} // namespace util + +namespace { + +// Obtain compilation log from the program. +std::string GetCompileLog(nvrtcProgram program) { + size_t log_size_including_null; + NVRTC_CALL(nvrtcGetProgramLogSize(program, &log_size_including_null)); + // For most std::string implementations, this is probably 1 char bigger than needed. OK though. Review comment: I studied your link more carefully and think my post above missed your point. Studying it further, I agree now that the following would work under C++11: ``` std::string GetCompileLog(nvrtcProgram program) { size_t log_size_including_null; NVRTC_CALL(nvrtcGetProgramLogSize(program, &log_size_including_null)); std::string log(log_size_including_null-1, '\0'); // Room for terminating null character ensured since C++11 NVRTC_CALL(nvrtcGetProgramLog(program, &log[0])); return log; } ``` I guess with the version currently in the PR, I was being conservative, not wanting to research the level of C++11 support in all the compilers MXNet was going to see. Do you see any difference between &log[0] and log.data() in terms of ensuring the compiler adheres to its contract of providing size()+1 bytes of contiguous storage? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
