DickJC123 commented on a change in pull request #18424:
URL: https://github.com/apache/incubator-mxnet/pull/18424#discussion_r459109387
##########
File path: src/c_api/c_api_test.cc
##########
@@ -106,3 +106,25 @@ int MXRemoveSubgraphPropertyOpNamesV2(const char*
prop_name) {
}
API_END();
}
+
+int MXGetEnv(const char* name,
+ const char** value) {
+ API_BEGIN();
+ *value = getenv(name);
+ API_END();
+}
+
+int MXSetEnv(const char* name,
+ const char* value) {
+ API_BEGIN();
+#ifdef _WIN32
Review comment:
The sequence we follow of checkpoint_env_vars, change_env_vars,
run_test, reinstate_env_vars, is fundamentally not thread-safe. I'm not making
those guarantees, so no mutex is required I feel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
