Zha0q1 opened a new pull request #18782:
URL: https://github.com/apache/incubator-mxnet/pull/18782


   ## Description ##
   Check if syrk_batch works correctly with large tensors. This test will fail 
with the current code base; 
https://github.com/apache/incubator-mxnet/pull/18752 should fix it.
   
   TODO:
   1. make test function naming consistent with other large tensor tests (need 
to rebase after any of those tests are merged)
   2. merge this only after the fix has been merged
   
   This test passes on both BLAS int32 and 64 builds.
   
   
   ```
   ubuntu@ip-172-31-43-103:~$ MXNET_TEST_COUNT=10000 nosetests 
--logging-level=DEBUG --verbose -s 
mxnet/tests/nightly/test_large_array.py:test_linalg_operators
   test_large_array.test_linalg_operators ... [23:14:57] 
../src/storage/storage.cc:198: Using Pooled (Naive) StorageManager for CPU
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 637.245s
   
   OK
   ```
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to