access2rohit commented on a change in pull request #18816:
URL: https://github.com/apache/incubator-mxnet/pull/18816#discussion_r462769587
##########
File path: tests/nightly/test_large_array.py
##########
@@ -1350,6 +1351,50 @@ def run_trsm(inp):
check_batch_trsm()
+def test_linalg_large_dim():
+ def check_gemm():
+ A = nd.ones(shape=(1, INT32_MAX + 1, 1))
Review comment:
@Zha0q1 We vector file generally houses tests for operators with a
single dimension that exceeds 2^32 range. Kindly address what is suggested by
@ChaiBapchya and move it to vector tests.
##########
File path: tests/nightly/test_large_array.py
##########
@@ -1350,6 +1351,50 @@ def run_trsm(inp):
check_batch_trsm()
+def test_linalg_large_dim():
+ def check_gemm():
+ A = nd.ones(shape=(1, INT32_MAX + 1, 1))
Review comment:
@Zha0q1 We vector file generally houses tests for operators with a
single dimension that exceeds 2^32 range. Please address what is suggested by
@ChaiBapchya and move it to vector tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
