szha commented on a change in pull request #8512: gluon rnn refactor
URL: https://github.com/apache/incubator-mxnet/pull/8512#discussion_r150146499
##########
File path: python/mxnet/gluon/contrib/rnn/conv_rnn_cell.py
##########
@@ -210,8 +214,10 @@ def hybrid_forward(self, F, inputs, states, i2h_weight,
i2h, h2h = self._conv_forward(F, inputs, states,
i2h_weight, h2h_weight, i2h_bias,
h2h_bias,
prefix)
- output = self._get_activation(F, i2h + h2h, self._activation,
- name=prefix+'out')
+ if F is symbol:
+ output = self.activation(i2h + h2h, prefix+'out')
Review comment:
This is so that the prefix (which depends on time-step) can be consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
