piiswrong commented on a change in pull request #8662: 2bit gradient compression
URL: https://github.com/apache/incubator-mxnet/pull/8662#discussion_r151235746
##########
File path: src/kvstore/kvstore_dist.h
##########
@@ -181,16 +223,21 @@ class KVStoreDist : public KVStoreLocal {
RunContext rctx, Engine::CallbackOnComplete cb) {
// convert to ps keys
size_t size = recv_buf.shape().Size();
- PSKV& pskv = EncodeKey(key, size);
+
+ // even if inactive should use compressed_pskv for pull when type is
not none
Review comment:
This doesn't make sense. What does active mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
