rahul003 commented on a change in pull request #8766: NDArray Indexing tutorial 
and Gradient Compression FAQ
URL: https://github.com/apache/incubator-mxnet/pull/8766#discussion_r152470029
 
 

 ##########
 File path: python/mxnet/kvstore.py
 ##########
 @@ -408,6 +408,8 @@ def set_gradient_compression(self, compression_params):
             Other keys in this dictionary are optional and specific to the type
             of gradient compression.
         """
+        if (self.type() == 'device') or ('dist' in self.type()):
 
 Review comment:
   Please pull this file from my updated branch gc-docs. It fixes the mistake 
here. 
   
   I'm linking the file from that branch here 
https://github.com/rahul003/mxnet/blob/gc-docs/python/mxnet/kvstore.py

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to