piiswrong commented on a change in pull request #8719: Tune without Launch specialization macros URL: https://github.com/apache/incubator-mxnet/pull/8719#discussion_r152677489
########## File path: src/operator/operator_tune.cc ########## @@ -125,16 +125,16 @@ struct static_init_var { * \brief Implement tuning objects for a backward unary kernel operator */ #define _IMPLEMENT_UNARY_WORKLOAD_BWD(__op$, __typ$) \ Review comment: can we simplify these macros a little? maybe by wrapping all static variables in a struct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services