marcoabreu commented on a change in pull request #8960: [Do not merge] Move to
new CI
URL: https://github.com/apache/incubator-mxnet/pull/8960#discussion_r155163167
##########
File path: Jenkinsfile
##########
@@ -52,12 +52,12 @@ def init_git_win() {
def make(docker_type, make_flag) {
timeout(time: max_time, unit: 'MINUTES') {
try {
- sh "${docker_run} ${docker_type} make ${make_flag}"
+ sh "${docker_run} ${docker_type} --dockerbinary docker make ${make_flag}"
Review comment:
Dockerbinary specifies whether the command has to be executed in
nvidia-docker (bringing GPU support) or in regular docker (to run on CPU-only
instances). We can't modify docker_run because it's a shared template and every
task has to specify the docker-binary it has to run in. In the current CI, the
docker-binary is determined automatically, depending on the name of the
Dockerfile - but I'd like to follow a declarative approach instead of automatic
assumptions and hardcoded names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
