cjolivier01 commented on a change in pull request #8972: Profiling
enhancements, python API, vtune and chrome tracing objects, etc.
URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r155409145
##########
File path: src/storage/storage.cc
##########
@@ -149,6 +155,9 @@ void StorageImpl::DirectFree(Storage::Handle handle) {
return nullptr;
});
this->ActivateDevice(ctx);
+#if MXNET_USE_PROFILER
+ profiler_.OnFree(handle);
Review comment:
I put it before in case Free() throws some sort of exception, it will still
remove it. I can put it on the other side if you like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
