cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-350503085 I mean, it can get as compact as being a couple of calls that take enumerated and optional arguments and then internally all of the possibilities get dispatched. Is this preferred? So far I haven?t seen a convention of squeezing down APIs like this in mxnet but I have no problem doing it ? it?s not hard to do. I was going for API usability and readability here. On Sat, Dec 9, 2017 at 11:52 AM Chris Olivier <cjolivie...@gmail.com> wrote: > I suppose crate start and stop can take an enumeration on type, but that > gets sort of cryptic. > > On Sat, Dec 9, 2017 at 10:50 AM Eric Junyuan Xie <notificati...@github.com> > wrote: > >> This adds too many CAPIs is there a better approach? >> >> ? >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-350497570>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AKts_avMfb85tIc5TVFrlByBKtl2yg5oks5s-tZqgaJpZM4Q4hdI> >> . >> >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
