piiswrong commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156206914
########## File path: include/mxnet/ndarray.h ########## @@ -608,6 +549,37 @@ class NDArray { << "CheckAndAllocAuxData is not intended for kDefaultStorage"; ptr_->CheckAndAllocAuxData(i, aux_shape); } + +#if MXNET_USE_MKLDNN == 1 + /* + * This function returns mkldnn::memory with the default primitive_desc. + */ + std::shared_ptr<const mkldnn::memory> GetMKLDNNData() const; Review comment: we probably don't need shared ptr, since this is called from inside operator and the NDArray itself will not be released during this time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services