piiswrong commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156265847
########## File path: src/operator/nn/activation.cu ########## @@ -31,39 +31,73 @@ namespace mxnet { namespace op { + +#if MXNET_USE_CUDNN == 1 + +template<typename DType> +static CuDNNActivationOp<DType> &get_cudnn_op(const ActivationParam& param) { +#if DMLC_CXX11_THREAD_LOCAL + static thread_local CuDNNActivationOp<DType> cudnn_op; +#else + static MX_THREAD_LOCAL CuDNNActivationOp<DType> cudnn_op; Review comment: we can probably drop support for non DMLC_CXX11_THREAD_LOCAL. I think it only affects vs 13? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services