reminisce commented on a change in pull request #8732: rsp push and rsp pull for comm device, used in kvstore('device') URL: https://github.com/apache/incubator-mxnet/pull/8732#discussion_r159149311
########## File path: src/kvstore/comm.h ########## @@ -681,8 +749,9 @@ class CommDevice : public Comm { } for (size_t i = 0; i < sorted_key_attrs_.size(); ++i) { int key = std::get<0>(sorted_key_attrs_[i]); Review comment: const int ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services