marcoabreu commented on issue #9330: Add clang job to the CI URL: https://github.com/apache/incubator-mxnet/pull/9330#issuecomment-356566736 Great, thanks for the explanation, Chris and Kellen! In that case I totally agree that we should run both jobs. On Wed, Jan 10, 2018 at 11:34 AM, Kellen Sunderland < [email protected]> wrote: > @marcoabreu <https://github.com/marcoabreu> +1 to what Chris is saying. > We generally run with OPEN_MP disabled, and I personally have been unable > to build a few times with this configuration. > > At a minimum I would like to test an older clang with OPEN_MP disabled. I > would optionally also agree to use a new Clang with OPEN_MP enabled. I > think having both makes sense, but I only feel strongly about the first one. > > Some motivation for running both in the future: We should keep in mind > that at some point we'll have to do some CMake work to detect if OPEN_MP is > supported on the version of Clang users are compiling with. When we do > start modifying CMake it would be quite nice to catch any errors here. > Proper testing would require you to run both environments, and mistakes can > quite easily slip through. (I've made plenty CMake errors like this in the > past). > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/9330#issuecomment-356563102>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ARxB601rhEb-Arxktw052ePIHqIs-a1dks5tJJJNgaJpZM4RVZfj> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
