cjolivier01 commented on a change in pull request #9371: Fix unit test build
URL: https://github.com/apache/incubator-mxnet/pull/9371#discussion_r160801246
##########
File path: tests/cpp/misc/memory_test.cc
##########
@@ -64,40 +64,40 @@ TEST(MEMORY_TEST, MemsetAndMemcopyPerformance) {
std::cout << "====================================" << std::endl
<< "Data size: " << test::pretty_num(test_size) << std::endl <<
std::flush;
- std::unique_ptr<uint8_t> buffer_1(new uint8_t[test_size]), buffer_2(new
uint8_t[test_size]);
- uint8_t *src = buffer_1.get(), *dest = buffer_2.get();
+ std::unique_ptr<float> buffer_1(new float[test_size]), buffer_2(new
float[test_size]);
Review comment:
so that memcpy (for example) similates the more common use-case of float
items rather than byte count
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
