tornadomeet commented on a change in pull request #9348: support regex of
collect_params()
URL: https://github.com/apache/incubator-mxnet/pull/9348#discussion_r161120194
##########
File path: python/mxnet/gluon/block.py
##########
@@ -253,7 +253,7 @@ def collect_params(self, select=None):
The selected :py:class:`ParameterDict`
"""
ret = ParameterDict(self._params.prefix)
- if select is None:
+ if not select:
Review comment:
if select = `[]` or `{}` or `''` or `()` then not select will be True, may
be wrong here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
