cjolivier01 commented on a change in pull request #9426: header updates to clarify use of CODEOWNERS URL: https://github.com/apache/incubator-mxnet/pull/9426#discussion_r161417310
########## File path: CODEOWNERS ########## @@ -1,4 +1,17 @@ # Owners of Apache MXNet +# Please see documentation of use of CODEOWNERS file at +# https://help.github.com/articles/about-codeowners/ and +# https://github.com/blog/2392-introducing-code-owners +# +# The first owner listed for a package is considered the maintainer for a package. +# Anybody can add themselves or a team (see https://help.github.com/articles/about-teams/) +# as additional owners to get notified about changes in a specific package. +# +# By default the package maintainer should merge PR after appropriate review. +# A PR which received 2 +1 (or LGTM) comments can be merged by any committer. Review comment: I still maintain that any committer can merge something if they feel they've given it a good review -- this encourages people to learn new parts of the code and allows the project to scale. The rule as stated above would mean that only a few people would be "allowed" to merge code at all, which sounds more like an internal corporate style and does not promote community, IMHO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
