piiswrong commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r161928578
##########
File path: src/kvstore/kvstore_local.h
##########
@@ -256,7 +256,13 @@ class KVStoreLocal : public KVStore {
auto validator = [this](const int key, const NDArray& nd) -> bool {
auto stype = nd.storage_type();
// valid NDArray
- if (stype == kDefaultStorage || stype == kRowSparseStorage) return true;
+ auto valid_stype = stype == kDefaultStorage || stype ==
kRowSparseStorage;
+#if MXNET_USE_MKLDNN == 1
+ // When it's kMKLDNNStorage, it'll be converted to a data layout
+ // compatible to the default storage.
+ valid_stype = valid_stype || stype == kMKLDNNStorage;
Review comment:
revert?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
