zheng-da commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r161940072
##########
File path: src/storage/cpu_device_storage.h
##########
@@ -54,7 +54,11 @@ class CPUDeviceStorage {
/*!
* \brief Alignment of allocation.
*/
+#if MXNET_USE_MKLDNN == 1
+ static constexpr size_t alignment_ = 4096;
Review comment:
MKLDNN requires memory to have alignment > 16. I'm not entirely sure what is
the best alignment. The MKLDNN library uses 4096, so I use 4096.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
