reminisce commented on a change in pull request #9464: refactor logging in
infer storage pass
URL: https://github.com/apache/incubator-mxnet/pull/9464#discussion_r161968768
##########
File path: src/operator/operator_common.h
##########
@@ -479,67 +480,11 @@ inline void ParamParser(nnvm::NodeAttrs* attrs) {
<< ") == " << param << ".shape[0] (" << rsp.shape()[0] << ").";
\
}
-/*! \brief get string representation of the operator stypes */
-inline std::string operator_stype_string(const nnvm::NodeAttrs& attrs,
- const int dev_mask,
- const std::vector<int>& in_attrs,
- const std::vector<int>& out_attrs) {
- std::string result = "";
- result += "operator = " + attrs.op->name + "\n";
- result += "input storage types = [";
- for (const auto attr : in_attrs) {
- result += common::stype_string(attr) + ", ";
- }
- result += "]\n";
- result += "output storage types = [";
- for (const auto attr : out_attrs) {
- result += common::stype_string(attr) + ", ";
- }
- result += "]\n";
- result += "params = {";
- for (auto kv : attrs.dict) {
- result += "\"" + kv.first + "\" : " + kv.second + ", ";
+#define LOG_UNIMPLMENTED_OP(attrs, ctx, inputs, req, outputs)
\
Review comment:
This looks like a function. It's normally preferred to define functions over
macros since macros has several side effects, such as no type check, global
name scope, no step-into in debugging, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
