eric-haibin-lin commented on a change in pull request #9464: refactor logging
in infer storage pass
URL: https://github.com/apache/incubator-mxnet/pull/9464#discussion_r161969301
##########
File path: src/executor/infer_graph_attr_pass.cc
##########
@@ -50,7 +50,15 @@ bool ApplyOpInferAttr<int, FInferStorageType>(const
nnvm::Graph& g,
std::vector<int>* out_attrs,
DispatchMode* dispatch_mode) {
const DevMaskVector& dev_masks = g.GetAttr<DevMaskVector>("dev_mask");
- return finfer(attrs, dev_masks[nid], dispatch_mode, in_attrs, out_attrs);
+ const bool success = finfer(attrs, dev_masks[nid], dispatch_mode, in_attrs,
out_attrs);
+ if (!success) {
Review comment:
Current `finferstorage` returns false only on the cases where some ops are
not implemented at all, such as `_sparse_retain(csr,csr)`. InferStorageType
only happens once
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
