eric-haibin-lin commented on a change in pull request #9468: standard adam
update for sparse tensor
URL: https://github.com/apache/incubator-mxnet/pull/9468#discussion_r162130287
##########
File path: tests/python/unittest/test_optimizer.py
##########
@@ -520,10 +520,10 @@ def test_adam():
not kwarg['multi_precision'])):
continue
compare_optimizer(opt1(**kwarg), opt2(**kwarg), shape,
dtype)
- if (default_context() == mx.cpu()):
- compare_optimizer(opt1(sparse_update=True,
**kwarg), opt2(**kwarg), shape,
Review comment:
Nope. Maybe at that time cast_storage on gpu is not ready
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
