cjolivier01 commented on issue #9389: [SUBMODULE] Upgrade ps-lite to the latest version URL: https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-359224755 I am fine merging it at any time. Haibin? On Sat, Jan 20, 2018 at 9:11 PM Nan Zhu <[email protected]> wrote: > @eric-haibin-lin <https://github.com/eric-haibin-lin> @cjolivier01 > <https://github.com/cjolivier01> what's the current agreement for this? I > do not mind merging it after 1.0.1 release. Regarding whether we need to > merge together with the changes which depends on this, I would prefer > merging this first, because > > 1. > > it has been tested with ps-lite tests for core functionality (actually > also tested with Spark in my own environment) and this change should not > bring influences to the existing functionalities in mxnet > 2. > > the other changes like Spark integration has their own focuses, I do > not want to mix them with the mxnet changes here. It would bring some > conveniences, for example, even if the changes here has some expected issue > influencing other functionalities , it would be reverted easily; it will > not block the merging of other updates in ps-lite if any > > ? > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/9389#issuecomment-359224549>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AKts_SreiMvexG5n6g1OheIDw4Jf2q0pks5tMscVgaJpZM4RbyQC> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
