piiswrong commented on a change in pull request #8972: Profiling enhancements,
python API, vtune and chrome tracing objects, etc.
URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r164211317
##########
File path: python/mxnet/profiler.py
##########
@@ -20,28 +20,34 @@
# pylint: disable=too-many-branches, too-many-statements
"""Profiler setting methods."""
from __future__ import absolute_import
-
import ctypes
-from .base import _LIB, check_call, c_str
+from .base import _LIB, check_call, c_str, ProfileHandle, c_str_array
-def profiler_set_config(mode='symbolic', filename='profile.json'):
+def profiler_set_config(flags):
"""Set up the configure of profiler.
Parameters
----------
- mode : string, optional
- Indicates whether to enable the profiler, can
- be 'symbolic', or 'all'. Defaults to `symbolic`.
- filename : string, optional
- The name of output trace file. Defaults to 'profile.json'.
+ flags : list of key/value pair tuples
+ Indicates configuration parameters
+ profile_all : boolean, all profile types enabled
Review comment:
mode='all|symbolic|imperative|api|memory' to keep backward compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
