mbaijal commented on a change in pull request #9548: updated release version to
1.0.1 on the mainpage and re-arranged news?
URL: https://github.com/apache/incubator-mxnet/pull/9548#discussion_r164256910
##########
File path: docs/_static/mxnet-theme/index.html
##########
@@ -17,27 +17,26 @@
</div>
</div>
</div>
-
<div class="section-tout">
<div class="container">
<div class="row">
<div class="col-lg-4 col-sm-12">
- <h3>Apache MXNet 1.0 Released</h3>
- <p>We're excited to announce the release of MXNet 1.0! Check out the
release notes for latest updates.</p>
- <a
href="https://github.com/apache/incubator-mxnet/releases/tag/1.0.0";>Learn
More</a>
+ <h3>Apache MXNet 1.0.1 Released</h3>
+ <p>We're excited to announce the release of MXNet 1.0.1! Check out the
release notes for latest updates.</p>
+ <a
href="https://github.com/apache/incubator-mxnet/releases/tag/1.0.1";>Learn
More</a>
Review comment:
Ideally, It should be `1.1.0` everywhere. Once the RC is created, no src can
be modified so it must be the final release tag.
However, This would lead to a broken link on the website and I think this
should only be merged onto the release branch for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
