reminisce commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r164917575
##########
File path: src/operator/nn/convolution-inl.h
##########
@@ -118,6 +118,29 @@ struct ConvolutionParam : public
dmlc::Parameter<ConvolutionParam> {
this->cudnn_off == other.cudnn_off &&
this->layout == other.layout;
}
+#if MXNET_USE_MKLDNN == 1
+ static uint64_t ComputeHash(const TShape &shape) {
Review comment:
What is this needed for? Why not use `dmlc::HashCombine`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
