szha commented on a change in pull request #9633: Gluon image-classification
example improvement
URL: https://github.com/apache/incubator-mxnet/pull/9633#discussion_r164931533
##########
File path: example/gluon/image_classification.py
##########
@@ -17,36 +17,49 @@
from __future__ import division
-import argparse, time
+import argparse, time, os
import logging
-logging.basicConfig(level=logging.INFO)
import mxnet as mx
from mxnet import gluon
from mxnet.gluon import nn
from mxnet.gluon.model_zoo import vision as models
from mxnet import autograd as ag
from mxnet.test_utils import get_mnist_iterator
+from mxnet.metric import Accuracy, TopKAccuracy, CompositeEvalMetric
+import numpy as np
from data import *
+# logging
+logging.basicConfig(level=logging.INFO)
+fh = logging.FileHandler('image-classification.log')
+logger = logging.getLogger()
+logger.addHandler(fh)
+formatter = logging.Formatter('%(message)s')
+fh.setFormatter(formatter)
+fh.setLevel(logging.DEBUG)
+logging.debug('\n%s', '-' * 100)
+formatter = logging.Formatter('%(asctime)s %(levelname)s %(message)s')
+fh.setFormatter(formatter)
+
# CLI
parser = argparse.ArgumentParser(description='Train a model for image
classification.')
parser.add_argument('--dataset', type=str, default='cifar10',
- help='dataset to use. options are mnist, cifar10, and
dummy.')
-parser.add_argument('--train-data', type=str, default='',
- help='training record file to use, required for imagenet.')
-parser.add_argument('--val-data', type=str, default='',
- help='validation record file to use, required for
imagenet.')
+ help='dataset to use. options are mnist, cifar10, imagenet
and dummy.')
+parser.add_argument('--data', type=str, default='',
+ help='training directory of imagenet images, contains
train/val subdirs.')
Review comment:
make sure that the name of the option reflects that it's for a directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
