piiswrong commented on a change in pull request #9681: Better Exception 
Handling for Operators
URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165726063
 
 

 ##########
 File path: src/engine/threaded_engine.cc
 ##########
 @@ -391,6 +400,11 @@ void ThreadedEngine::WaitForAll() {
   finished_cv_.wait(lock, [this]() {
       return pending_.load() == 0 || kill_.load();
     });
+  if (global_ex_ptr) {
+    std::exception_ptr ex_ptr = global_ex_ptr;
 
 Review comment:
   use std::rethrow_exception(std::move(global_ex_ptr))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to