anirudh2290 commented on a change in pull request #9681: Better Exception
Handling for Operators
URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165773582
##########
File path: src/engine/threaded_engine.h
##########
@@ -175,6 +175,8 @@ class ThreadedVar final
static std::atomic<std::size_t> counter;
~ThreadedVar() { LOG(INFO) << __func__ << " " << --counter; }
#endif // ENGINE_DEBUG
+ /*! \brief exception_ptr associated with the ThreadedVar */
+ std::exception_ptr ex_ptr;
Review comment:
i changed ex_ptr for var to var_exception, ex_ptr for opr to opr_exception
and the global exception_ptr global_exception_ . I welcome if you have any
other suggestions for naming them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
