larroy commented on a change in pull request #9761: Don't use FIRST_CUDA on
generators which don't support toolsets
URL: https://github.com/apache/incubator-mxnet/pull/9761#discussion_r167871781
##########
File path: CMakeLists.txt
##########
@@ -1,6 +1,8 @@
cmake_minimum_required(VERSION 3.0.2)
-
-if((${CMAKE_VERSION} VERSION_GREATER "3.9.0") OR (${CMAKE_VERSION}
VERSION_EQUAL "3.9.0"))
+message(STATUS "CMake version '${CMAKE_VERSION}' using generator
'${CMAKE_GENERATOR}'")
+if(((${CMAKE_GENERATOR} MATCHES "Visual Studio.*") OR (${CMAKE_GENERATOR}
MATCHES "Xcode.*"))
Review comment:
Hi Chris. I tested cmake 3.5.1 in Linux using Makefiles and Ninja and cmake
3.9.6 under CLion using Make and both work with my commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
