cjolivier01 commented on issue #9761: Don't use FIRST_CUDA on generators which don't support toolsets URL: https://github.com/apache/incubator-mxnet/pull/9761#issuecomment-365294184 simply building isn?t what was broken ? cmake knowing how to build cuda files natively was broken by your change, which increases build time significantly. On Tue, Feb 13, 2018 at 6:01 AM Pedro Larroy <notificati...@github.com> wrote: > *@larroy* commented on this pull request. > ------------------------------ > > In CMakeLists.txt > <https://github.com/apache/incubator-mxnet/pull/9761#discussion_r167871781> > : > > > @@ -1,6 +1,8 @@ > cmake_minimum_required(VERSION 3.0.2) > - > -if((${CMAKE_VERSION} VERSION_GREATER "3.9.0") OR (${CMAKE_VERSION} VERSION_EQUAL "3.9.0")) > +message(STATUS "CMake version '${CMAKE_VERSION}' using generator '${CMAKE_GENERATOR}'") > +if(((${CMAKE_GENERATOR} MATCHES "Visual Studio.*") OR (${CMAKE_GENERATOR} MATCHES "Xcode.*")) > > Hi Chris. I tested cmake 3.5.1 in Linux using Makefiles and Ninja and > cmake 3.9.6 under CLion using Make and both work with my commit. > > ? > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/9761#discussion_r167871781>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AKts_Z99zE74TKYigjLhOOo5xxCjdeOIks5tUZWogaJpZM4SA5Lj> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
